Skip to content

feat: change log level for decider exceptions #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

feat: change log level for decider exceptions #116

merged 1 commit into from
Nov 2, 2023

Conversation

aleksgapp
Copy link
Contributor

💸 TL;DR

Upcast info to error logging for DeciderException exceptions.

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@aleksgapp aleksgapp requested a review from mrlevitas October 27, 2023 13:48
@aleksgapp aleksgapp force-pushed the into-to-warn-for-decier-exceptions branch from b4c4fc3 to ccd0c9b Compare October 27, 2023 13:58
@mrlevitas mrlevitas self-requested a review October 27, 2023 16:44
@mrlevitas
Copy link
Contributor

Some ci failures
Screenshot_20231027-094336

@aleksgapp aleksgapp force-pushed the into-to-warn-for-decier-exceptions branch from ccd0c9b to ff7d3d7 Compare October 27, 2023 18:12
@aleksgapp aleksgapp merged commit d197353 into develop Nov 2, 2023
@aleksgapp aleksgapp deleted the into-to-warn-for-decier-exceptions branch November 2, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrlevitas mrlevitas mrlevitas approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksgapp @mrlevitas