Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #69: missing first word in sse response for example_app #81

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

wliu6v
Copy link
Contributor

@wliu6v wliu6v commented Nov 22, 2023

The example app will retrieve the corresponding item with the message.id from the list after each response is returned, and append the returned content to it. However, the first response is discarded (because the message object is null, so the message?.message = .... does not function properly).

After merging PR #80, due to the SSE fix, the first response that sets the role (where message is empty) can now correctly return to the example app. Therefore, even if the example app discards the message from the first return, there is no significant impact. However, this is not reasonable, so a fix is needed for this issue.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58ec1dc) 83.87% compared to head (dff7076) 83.87%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files          71       71           
  Lines        1048     1048           
=======================================
  Hits          879      879           
  Misses        169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@redevrx redevrx merged commit 1dc476e into redevrx:main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants