fix: allow a deployment without Pipelines

[Roming22]

cf RHTAP-6460

Since another CI system may be used, Pipelines is optional.

• Modified values.yaml.tpl and values.yaml to enable pipelines configurations.
• Updated patch-serviceaccounts.yaml run based on the new configuration.
• Modified extra-env.yaml to always include GITHUB__HOST.

Summary by CodeRabbit

• Chores
  • Introduced a new configuration setting for pipelines that can be toggled on or off during deployment, giving operators greater control over feature availability
  • Improved GitHub integration by streamlining host configuration settings to ensure they are consistently applied throughout the application setup process
  • Enhanced template-based deployment configurations to provide more flexible control over optional features

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9c70080c-e1e4-44ff-9dd2-52c4f227f1bd

📥 Commits

Reviewing files that changed from the base of the PR and between dd701d0 and 0150fc4.

📒 Files selected for processing (4)

• installer/charts/tssc-app-namespaces/templates/serviceaccounts/patch-serviceaccounts.yaml
• installer/charts/tssc-app-namespaces/values.yaml
• installer/charts/tssc-dh/templates/extra-env.yaml
• installer/values.yaml.tpl

---

📝 Walkthrough

Walkthrough

Configuration and Helm template modifications add pipeline enablement logic across multiple installer charts. Changes include conditional Pod manifest rendering, new pipeline configuration values, and simplified GitHub host environment variable emission.

Changes

Cohort / File(s)	Summary
Pipeline Enablement Configuration installer/charts/tssc-app-namespaces/templates/serviceaccounts/patch-serviceaccounts.yaml, installer/charts/tssc-app-namespaces/values.yaml, installer/values.yaml.tpl	Added pipelines.enabled configuration and conditionally render the service account patch Pod template only when pipelines are enabled.
GitHub Integration Environment installer/charts/tssc-dh/templates/extra-env.yaml	Changed GITHUB__HOST environment variable to emit unconditionally, removing dependency on OpenShift Route lookup.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: patch ServiceAccount from a Job instead of a hook #1294: Directly related; modifies the same service account patch template with conditional rendering logic.

Suggested labels

approved, lgtm

Suggested reviewers

• otaviof
• dperaza4dustbit
• lingyzhuang

Poem

🐰 A pipeline's fate now rests on a flag,
Conditionals wrap what once would drag,
GitHub hosts need not wait or flee,
Configuration blooms wild and free! 🌟

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main objective: making Pipelines optional in deployments by allowing configurations to disable it.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Roming22]

/cherry-pick release-1.9

[openshift-cherrypick-robot]

@Roming22: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[dperaza4dustbit]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dperaza4dustbit, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Roming22]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@Roming22: new pull request created: #1764

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.