Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove output directory from file list for digest #410

Merged
merged 1 commit into from
Apr 23, 2024
Merged

remove output directory from file list for digest #410

merged 1 commit into from
Apr 23, 2024

Conversation

dcurran90
Copy link
Contributor

@dcurran90 dcurran90 commented Oct 11, 2023 •
edited
Loading

Added a filter function to remove output files created by chart-verifier from the list of files used to calculate the sha256 digest

Closes #316

@komish
Copy link
Contributor

komish commented Oct 17, 2023

Thanks @dcurran90 we'll consider this for the next release

komish
komish approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working how I expect, thanks @dcurran90

/lgtm

@komish komish merged commit a8fa028 into redhat-certification:main Apr 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komish komish komish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chart digest generation is impacted if you run chart-verifier from within the same directory as the chart
2 participants
@dcurran90 @komish