-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop extra .tgz from release artifact #464
Conversation
Thanks for your contribution ! This LGTM, @komish ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can you remove this modification from your commit? whoops - didn't highlight the code. See the next review request for a more accurate representation of what I meant!
I'm sorry, I may have made my modifications too fast. @komish , I removed the whitespace edit I unintentionally added. I'm unclear on if there was something else in your review you would like, as you said
I think you only meant to highlight the added newline character. |
@jessesimpson36 You nailed it, thank you! A quick sidenote, though, I'm fairly certain this doesn't fix the problem you're seeing, but it's still an extra tgz where it doesn't belong, so we'll get this merged shortly. The issue sits in how openshift-tools-installer is filtering our release assets. I'll look to pursue this either in our pipelines (renaming our assets) or directly with openshift-tools-installer itself. If I pursue the latter, I'll CC you into the conversation, should you want to follow along. For now, though, I've attached an extra release asset to our 1.13.6 so that your pipeline (and ours) will pass when using openshift-tools-installer. In my local testing with openshift-tools-installer, it picks up the right release asset now.
My apologies! We'll try to get this resolved before our next release. |
You're the best. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Related to #463
This commit will remove the duplicate .tgz extension from the tarball release artifact.