Sign release images #468
Merged
Sign release images #468
+37
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will run
Cosignin keyless mode to sign our tagged images (which are associated with the release process). Note that this is not the latest cosign Y-stream version, but is the same version we use in other places and know to work how we expect.This PR adds an additional GitHub Secret
secrets.IMAGE_REGISTRYand replaces hard-coded references to the same value. The secret is already configured for the repository. I've also moved the image name to an environment variable in-file. The combination of these changes makes it so you can more easily test this task in a fork (by setting your own secrets).In addition, this PR will change our strategy for managing the latest tag. The previous implementation would simply call
podman buildtwice and push the results. They would end up with different digests. Instead, we call it once, and taglatestonce the versioned image is built. That way, when pushed, they will be linked.