-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-44208: Fix Holdover Event Triggering for T-GM and Minimize Redundant Clock Class Events: #369
OCPBUGS-44208: Fix Holdover Event Triggering for T-GM and Minimize Redundant Clock Class Events: #369
Conversation
@aneeshkp: This pull request references Jira Issue OCPBUGS-44208, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@aneeshkp: This pull request references Jira Issue OCPBUGS-44208, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@aneeshkp: This pull request references Jira Issue OCPBUGS-44208, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
could you add unit test for the event? |
Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
e0547ee
to
48c32f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, jzding The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aneeshkp: Jira Issue OCPBUGS-44208: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44208 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: cloud-event-proxy |
This PR addresses two issues:
Fix Holdover Event Triggering for T-GM :
Issue: When the T-GM (Telecom Grandmaster) entered holdover mode, the associated events were not generated, although metrics were successfully created.
Resolution: This PR ensures that event generation is correctly triggered for the holdover state, aligning events with the metrics generated.
Eliminate Duplicate Clock Class Events:
Issue: Multiple events were being generated for the same clock class value, causing redundancy.
Resolution: Duplicate events for the same clock class value have been removed, streamlining event reporting and reducing noise.