Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-44208: Fix Holdover Event Triggering for T-GM and Minimize Redundant Clock Class Events: #369

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

aneeshkp
Copy link
Member

@aneeshkp aneeshkp commented Nov 4, 2024

This PR addresses two issues:

  1. Fix Holdover Event Triggering for T-GM :
    Issue: When the T-GM (Telecom Grandmaster) entered holdover mode, the associated events were not generated, although metrics were successfully created.
    Resolution: This PR ensures that event generation is correctly triggered for the holdover state, aligning events with the metrics generated.

  2. Eliminate Duplicate Clock Class Events:
    Issue: Multiple events were being generated for the same clock class value, causing redundancy.
    Resolution: Duplicate events for the same clock class value have been removed, streamlining event reporting and reducing noise.

@openshift-ci openshift-ci bot added the approved label Nov 4, 2024
@aneeshkp aneeshkp changed the title OCPBUGS-44208 : Fix Holdover Event Triggering for T-GM and Minimize Redundant Clock Class Events: OCPBUGS-44208: Fix Holdover Event Triggering for T-GM and Minimize Redundant Clock Class Events: Nov 4, 2024
@openshift-ci-robot
Copy link

@aneeshkp: This pull request references Jira Issue OCPBUGS-44208, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR addresses two issues:

  1. Fix Holdover Event Triggering for T-GM :
    Issue: When the T-GM (Telecom Grandmaster) entered holdover mode, the associated events were not generated, although metrics were successfully created.
    Resolution: This PR ensures that event generation is correctly triggered for the holdover state, aligning events with the metrics generated.

  2. Eliminate Duplicate Clock Class Events:
    Issue: Multiple events were being generated for the same clock class value, causing redundancy.
    Resolution: Duplicate events for the same clock class value have been removed, streamlining event reporting and reducing noise.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aneeshkp
Copy link
Member Author

aneeshkp commented Nov 4, 2024

/jira refresh

@openshift-ci-robot
Copy link

@aneeshkp: This pull request references Jira Issue OCPBUGS-44208, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aneeshkp
Copy link
Member Author

aneeshkp commented Nov 4, 2024

/jira refresh

@openshift-ci-robot
Copy link

@aneeshkp: This pull request references Jira Issue OCPBUGS-44208, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jzding
Copy link
Member

jzding commented Nov 5, 2024

could you add unit test for the event?

Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
Copy link
Member

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bacea3b into redhat-cne:main Nov 7, 2024
5 checks passed
@openshift-ci-robot
Copy link

@aneeshkp: Jira Issue OCPBUGS-44208: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44208 has been moved to the MODIFIED state.

In response to this:

This PR addresses two issues:

  1. Fix Holdover Event Triggering for T-GM :
    Issue: When the T-GM (Telecom Grandmaster) entered holdover mode, the associated events were not generated, although metrics were successfully created.
    Resolution: This PR ensures that event generation is correctly triggered for the holdover state, aligning events with the metrics generated.

  2. Eliminate Duplicate Clock Class Events:
    Issue: Multiple events were being generated for the same clock class value, causing redundancy.
    Resolution: Duplicate events for the same clock class value have been removed, streamlining event reporting and reducing noise.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cloud-event-proxy
This PR has been included in build cloud-event-proxy-container-v4.18.0-202411070208.p0.gbacea3b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants