-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/typos in docs #104
Bugfix/typos in docs #104
Conversation
@mikemorency Why didn't you specify dependencies for roles?
|
cluster_settings role: Suggestion:
Suggestion:
|
content_library role:
|
deploy_ovf:
|
export_vm_as_ovf role:
|
@anna-savina Most of our roles have no requirements like that. I did list some for the vcenter and esxi provisioning roles. Heres some examples for reference: |
2d8415a
to
f8f9479
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This fixes a ton of typos and grammatical errors throughout the collection. I used the document generated by QE to guide the changes.
I also tried to update the provision_vm documentation to be a bit more readable since that was noted as being particularly difficult by QE. I think its because there are so many options that were copied from the community module, leading to weird syntax.
I also updated our role dependency docs to match other validated content collections. They use that section to identify pre-req steps, system requirements, and other miscellaneous dependencies rather than python or collection deps.