Added test files which can be used by prow #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late reply. It seems like a good start for me! We can improve on top of this based on the apps, like if Jenkins agents are built also fine etc. |
|
hi @garethahealy, @ckavili - this has been sitting around for a while, looks like linting failed at the time ? still good to go ? |
|
@eformat ; just done a rebase. not sure why linting would have been failing, no charts have been changed only 1 extra file has been added into a chart dir. does that require a version bump? |
|
latest linting failure would suggest versions need a bump |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Attempting to bring this repo under CI/automated testing.
The general idea being:
.test.shscript, which runs helm template, test and cleanup._test/prow.shscript which runs all of them. which would be hooked up to prow, in the future.not all charts are tested, but 70% are. #15
How should this be tested?
_test/prow.sh