Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template-test: consider armv8l as arm #332

Merged
merged 1 commit into from
Feb 29, 2024
Merged

template-test: consider armv8l as arm #332

merged 1 commit into from
Feb 29, 2024

Conversation

ayakael
Copy link
Contributor

@ayakael ayakael commented Jan 26, 2024

No description provided.

@ayakael ayakael closed this Jan 28, 2024
@ayakael ayakael reopened this Jan 28, 2024
@ayakael
Copy link
Contributor Author

ayakael commented Jan 28, 2024

Current failure has to do with removing libcoreclrtraceptprovider.so due dotnet/runtime#57784. @omajid Is best practice still to remove that file since lttnng-ust tracing is still broken?

@ayakael ayakael closed this Jan 28, 2024
@ayakael ayakael reopened this Jan 28, 2024
@ayakael ayakael changed the title template-test: consider armv8l as arm template-test: consider armv8l as arm + disable lttng testing on alpine Jan 28, 2024
@omajid
Copy link
Member

omajid commented Jan 29, 2024

On Fedora/RHEL, we leave that file around. It doesn't seem to hurt anything as far as I can tell.

Also on Fedora/RHEL, with newer versions of .NET, we have made the dependency on lttng-ust optional at the distro-package-level. libcoreclrtraceptprovider.so correctly handles the case when lttng-ust is missing from the distro.

omajid
omajid reviewed Jan 29, 2024
View reviewed changes
lttng/test.json Outdated
@@ -12,6 +12,7 @@
"ignoredRIDs":[
"centos",
"fedora", // see https://github.com/redhat-developer/dotnet-regular-tests/issues/202
"alpine", // lttng tracing disabled due to no support for lttng-ust 2.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's an issue on github/gitlab/jira/whatever with details, linking to that would be nice too.

@ayakael ayakael changed the title template-test: consider armv8l as arm + disable lttng testing on alpine Draft: template-test: consider armv8l as arm + disable lttng testing on alpine Feb 13, 2024
@ayakael ayakael closed this Feb 14, 2024
@ayakael ayakael reopened this Feb 14, 2024
@ayakael ayakael closed this Feb 15, 2024
@ayakael ayakael reopened this Feb 15, 2024
@ayakael ayakael closed this Feb 15, 2024
@ayakael ayakael reopened this Feb 15, 2024
@ayakael ayakael changed the title Draft: template-test: consider armv8l as arm + disable lttng testing on alpine template-test: consider armv8l as arm Feb 16, 2024
@ayakael
Copy link
Contributor Author

ayakael commented Feb 16, 2024

I dropped the lttng changes as I adopted your approach to dealing with this bug. The test units passes now.

@omajid
Copy link
Member

omajid commented Feb 29, 2024

Thanks!

@omajid omajid merged commit 3a32e5a into redhat-developer:main Feb 29, 2024
69 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omajid omajid omajid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayakael @omajid