test for SHA1 CAs #347
Merged
test for SHA1 CAs #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omajid
reviewed
Mar 6, 2024
|
Test failures are unrelated except for .NET 8 on UBI9 which we wanted to fail. |
|
Do we want to check .NET 6 on UBI9? |
I tested .NET 6 on UBI9 locally and the issue was reproduced so I'll add it. |
omajid
reviewed
Mar 6, 2024
omajid
reviewed
Mar 6, 2024
CI doesn't reproduce the issue on .NET 6 on UBI 9 😕 |
Yeah, unfortunately I tested it when the target framework was set to .NET 8. |
tmds
reviewed
Mar 7, 2024
tmds
reviewed
Mar 7, 2024
tmds
reviewed
Mar 7, 2024
tmds
reviewed
Mar 7, 2024
tmds
reviewed
Mar 7, 2024
tmds
reviewed
Mar 7, 2024
tmds
reviewed
Mar 7, 2024
|
@nicrowe00 https://github.com/redhat-developer/dotnet-regular-tests/pull/347/files#r1515533814 should be addressed, the other comments are some minor suggestions. |
tmds
reviewed
Mar 7, 2024
tmds
reviewed
Mar 7, 2024
tmds
reviewed
Mar 7, 2024
tmds
reviewed
Mar 7, 2024
tmds
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.