Skip to content

chore(about): fix the illogical statement that we only run on AKS or EKS... if it's OCP #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nickboldt
Copy link
Member

What does this PR do?

chore(about): fix the illogical statement that we only run on AKS or EKS... if it's OCP

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…EKS... if it's OCP

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt changed the title chore(about): fix the illogical statement... chore(about): fix the illogical statement that we only run on AKS or EKS... if it's OCP Jan 8, 2025
@nickboldt
Copy link
Member Author

/cherry-pick release-1.4

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nickboldt
Copy link
Member Author

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jan 8, 2025

@Gerry-Forde
Copy link
Member

@jmagak Were you also working on this task?

@Gerry-Forde Gerry-Forde requested a review from jmagak January 8, 2025 22:03
@christophe-f
Copy link

Thanks for making this important update.

@nickboldt
Copy link
Member Author

@jmagak
Copy link
Member

jmagak commented Jan 9, 2025

@jmagak Were you also working on this task?

@Gerry-Forde , yes, I am working on updating the wording in the Supported Platforms section. Instead of a list, I have included a statement with a link to the RHDH Life cycle and supported platforms article. I have a PR already for the same, as @nickboldt has highlighted here.

@Preeticp
Copy link

Preeticp commented Jan 9, 2025

@nickboldt @christophe-f this is definitely an important update but please see the reasoning behind Judith's PR and my suggestion wrt some of the comments on that PR.

@themr0c
Copy link
Member

themr0c commented Jan 24, 2025

The conflict shows that the modified sentence has been removed from the docs in the main and release-1.4 branches. I believe we can close this pull request.

@jmagak
Copy link
Member

jmagak commented Jan 24, 2025

The conflict shows that the modified sentence has been removed from the docs in the main and release-1.4 branches. I believe we can close this pull request.

Sure @themr0c. We can close this PR as the supported platforms section has already been modified and changes published.

@themr0c themr0c closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants