Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme workspace with backstage app and theme web-library scaffold #27

Merged

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Nov 7, 2024

Hey, I just made a Pull Request!

A workspace to migrate https://github.com/redhat-developer/red-hat-developer-hub-theme to build it similar to our plugins and reuse all the automated tools and processes we use here!

It contains a workspace with the backstage app and a web-library plugin (scaffold only) that is marked as private, so that I can migrate the actual theme in a follow-up PR.

Using this dependency instead of the old one is a stretch goal for 1.4.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@christoph-jerolimov christoph-jerolimov changed the title Add theme workspace without theme yet Add theme workspace with backstage app and theme web-library scaffold Nov 7, 2024
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
Copy link
Member

@debsmita1 debsmita1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that the yarn dev starts the application without any errors
/lgtm

@nickboldt nickboldt merged commit da83eda into redhat-developer:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants