Add dynamic-home-page workspace with backstage app and plugin scaffold #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
7 tasks
christoph-jerolimov
changed the title
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
christoph-jerolimov
force-pushed
the
add-dynamic-home-page-workspace
branch
from
6ca2150
to
c81e0bd
Compare
christoph-jerolimov
changed the title
christoph-jerolimov
force-pushed
the
add-dynamic-home-page-workspace
branch
from
4c9dd7d
to
886b901
Compare
christoph-jerolimov
changed the title
christoph-jerolimov
force-pushed
the
add-dynamic-home-page-workspace
branch
from
886b901
to
2255e00
Compare
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
christoph-jerolimov
force-pushed
the
add-dynamic-home-page-workspace
branch
from
2255e00
to
31bc3ed
Compare
|
There are example and template folders with YAML files that the catalog locations use. Do you need these examples for your dynamic homepage? |
debsmita1
reviewed
Nov 8, 2024
04kash
approved these changes
Nov 8, 2024
Do you want this merged as is, or are you proposing adding more files to the PR first? |
|
Merge as it is, improve later. It should not contain examples, it should contain the code that is currently in the showcase repo
(Testing answering on the GitHub email)
|
|
Done
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
A workspace to extract/migrate https://github.com/janus-idp/backstage-showcase/tree/main/plugins/dynamic-home-page
It contains a workspace with the backstage app and a plugin (frontend scaffold) that is marked as private, so that I can migrate the code in a follow-up PR.
Replacing the bundled plugin in 1.4 would be nice, but that's a stretch goal.
✔️ Checklist