Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item-17-147 #408

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Sep 28, 2023

Screenshot from 2023-09-28 10-33-12

Considerations

No direct word usage entry exists in the IBM SG for "PC", but I did find usage info in the "microcomputer" word usage entry.

Screenshot from 2023-09-28 10-32-22

Issue

Closes number 17 in #147

Preview link

https://file.emea.redhat.com/dfitzmau/item-17-147/main.html#_p -- See the PC entry

@@ -46,7 +46,7 @@

[[pc]]
==== image:images/yes.png[yes] PC (noun)
*Description*: _PC_ is an abbreviation for personal computer. For more information, see the _IBM Style_ guide.
*Description*: _PC_ is an abbreviation for personal computer. For more information, see the _microcomputer_ entry in the *Word Usage* section of the _IBM Style_ guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ISG reference doesn't add any value. I'd just delete the second sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bredamc . So, drop the reference to the IBM SG?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's my preference, but see what other reviewers think :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removing the second sentence, since the ISG doesn't actually provide much additional guidance on using "PC"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Breda that we should drop the second sentence. The "microcomputer" entry isn't helpful in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bredamc , @bergerhoffer , and @mportman12 . Updated the content and the preview link.

@bergerhoffer bergerhoffer added the General update General updates to the guide or repo label Sep 28, 2023
Copy link
Contributor

@bredamc bredamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Collaborator

@mportman12 mportman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bergerhoffer bergerhoffer merged commit a1712db into redhat-documentation:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General update General updates to the guide or repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants