-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
item-17-147 #408
item-17-147 #408
Conversation
@@ -46,7 +46,7 @@ | |||
|
|||
[[pc]] | |||
==== image:images/yes.png[yes] PC (noun) | |||
*Description*: _PC_ is an abbreviation for personal computer. For more information, see the _IBM Style_ guide. | |||
*Description*: _PC_ is an abbreviation for personal computer. For more information, see the _microcomputer_ entry in the *Word Usage* section of the _IBM Style_ guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ISG reference doesn't add any value. I'd just delete the second sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bredamc . So, drop the reference to the IBM SG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's my preference, but see what other reviewers think :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with removing the second sentence, since the ISG doesn't actually provide much additional guidance on using "PC"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Breda that we should drop the second sentence. The "microcomputer" entry isn't helpful in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bredamc , @bergerhoffer , and @mportman12 . Updated the content and the preview link.
f98ce03
to
c561758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Considerations
No direct word usage entry exists in the IBM SG for "PC", but I did find usage info in the "microcomputer" word usage entry.
Issue
Closes number 17 in #147
Preview link
https://file.emea.redhat.com/dfitzmau/item-17-147/main.html#_p -- See the PC entry