Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a localization rule #676

Closed
wants to merge 1 commit into from
Closed

Create a localization rule #676

wants to merge 1 commit into from

Conversation

rolfedh
Copy link
Collaborator

@rolfedh rolfedh commented Oct 20, 2023

References #515

@rolfedh rolfedh marked this pull request as draft October 20, 2023 13:15
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-676.surge.sh 🎊

@rolfedh rolfedh requested a review from aireilly October 20, 2023 13:16
@rolfedh
Copy link
Collaborator Author

rolfedh commented Oct 20, 2023 •
edited
Loading

@aireilly Here's a first pass at a solution for this issue. I'd appreciate any suggestions.
Notes:

  • Although we have only one term, "should", that's problematic for localization at this time, it seems like other terms might come to light later on.
  • If possible, I'd like to have a Localization rule that is can handle multiple issues or terms.
  • However, users might require term-specific guidance that doesn't seem possible with the current proposed Localization rule. In that case, we might need separate rules for each term.

WDYT?

@rolfedh rolfedh added the hacktoberfest2023 Issues suitable for Hacktoberfest 2023 label Oct 20, 2023
@rolfedh
Copy link
Collaborator Author

rolfedh commented Nov 1, 2023

Creating a Localization rule set instead: #688

@rolfedh rolfedh closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aireilly aireilly Awaiting requested review from aireilly

Assignees
No one assigned
Labels
hacktoberfest2023 Issues suitable for Hacktoberfest 2023 hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rolfedh