vale-issue-672 - Use double quotes not single quotes in IDs #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses redhat-documentation#672 My regex knowledge leaves a lot to be disired but I made an attempt at adding this rule. As it relates to AsciiDoc syntax, I added to the AsciiDoc package. The tests pass when I run `vale .` but this could do with a sanity check. Any and all feedback welcome :)
|
Click here to review and test in web IDE: |
|
🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-711.surge.sh 🎊 |
|
Again - thanks for the PR. We appreciate it! Unfortunately, we won't merge this since single and double quotes are both perfectly valid in AsciiDoc once they are not mixed. Reach out on slack if you'd like to be assigned some other tasks! There is lots in the queue :) |
|
No problem, thanks for the feedback, I'll close this out :) I certainly will reach out on Slack, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #672
My regex knowledge leaves a lot to be disired but I made an attempt at adding this rule.
As it relates to AsciiDoc syntax, I added to the AsciiDoc package.
The tests pass when I run
vale .but this could do with a sanity check.Any and all feedback welcome :)