Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ham kebab #716

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Ham kebab #716

merged 2 commits into from
Mar 12, 2024

Conversation

neal-timpe
Copy link
Contributor

@neal-timpe neal-timpe commented Feb 9, 2024

As part of the work that Aedín and Monica are working on, we're proposing a rule to fix lines 8 and 9 in https://docs.google.com/spreadsheets/d/1mTLbaMsZyxDKRmNN6BryFQbq0jA9bcgBDf2uFKhJ8jE/edit#gid=0. We shouldn't be using the terms hamburger or kebab menus in our documentation. We should be using the names of the menus in the UI.

Copy link

github-actions bot commented Feb 9, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Feb 9, 2024

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-716.surge.sh 🎊

Copy link
Member

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aireilly
Copy link
Member

One thought. If we add these terms to the https://github.com/redhat-documentation/vale-at-red-hat/blob/main/.vale/styles/RedHat/TermsWarnings.yml rule, we can create substitution terms which allows the user to click replace the term. IMO this is preferable esp when a sub term exists.

@aireilly aireilly merged commit 5980097 into redhat-documentation:main Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants