Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing double quotes in alert messages with single quotes. #717

Merged

Conversation

rohennes
Copy link
Collaborator

@rohennes rohennes commented Feb 9, 2024

Double quotes within the message body causes problems for further processing with other programs. For example, I get confused JSON converting to JSON

{"body":"Module is missing the "_mod-docs-content-type" variable.","path":"test.adoc","line":1}

Changing the 3 instances in the OCP rule set so it will read like the following, which is easier JSON to process.

{"body":"Module is missing the '_mod-docs-content-type' variable.","path":"test.adoc","line":1}

Using single quotes in messages is also the format used in other rule sets.

…quotes within the message value causes problems for further processing with other programs, messes up JSON etc
Copy link

github-actions bot commented Feb 9, 2024

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-717.surge.sh 🎊

Copy link

github-actions bot commented Feb 9, 2024

Click here to review and test in web IDE: Contribute

Copy link
Member

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aireilly aireilly merged commit 5068a60 into redhat-documentation:main Feb 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants