-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding a new policy that allows scratch and root policy exceptions #1184
adding a new policy that allows scratch and root policy exceptions #1184
Conversation
from change #1184: |
… the same time Signed-off-by: Adam D. Cornett <adc@redhat.com>
65fd541
to
87367e0
Compare
from change #1184: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation
Some partners need to run containers as both root and scratch for some of their product(s). Currently, we only allow for one of these exceptions at a time.
Explanation
This PR creates a net new
Policy
that runs a subset of checks, excluding any checks that do not appear in the current root and current scratch policy. Some existing policy names/variables were also refactored to provide better clarity.Testing
Aside from the unit test updates, this was tested in
stage
with project668ed5d57f921e72f6431c4c
and below are the results.Additional Info
More info and business approval for a new policy can be found in