Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding PyxisHost value to ContainerCheckConfig for ubi check #1212

Merged

Conversation

acornett21
Copy link
Contributor

Motivation

To be able to lookup pre-prod ubi images in pyxis for testing.

Fix

Add PyxisHost as to the ContainerCheckConfig, and use the value of of c.pyxisHost that we have from the checkContainer struct.

…zation

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@acornett21 acornett21 requested review from bcrochet and komish November 8, 2024 22:04
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@dcibot
Copy link

dcibot commented Nov 8, 2024

@acornett21
Copy link
Contributor Author

/test 4.17-e2e

@acornett21
Copy link
Contributor Author

/test 4.17-images

Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
Copy link

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 0184783 into redhat-openshift-ecosystem:main Nov 18, 2024
5 checks passed
@acornett21 acornett21 deleted the fix_pyxis_default branch November 18, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants