Refactor bootstrap role to align with Ansible best practices #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjeanner
force-pushed
the
refactor/bootstrap
branch
2 times, most recently
from
07488b1 to
0bd9800
Compare
- Use fully qualified module names (ansible.builtin.*) throughout - Convert boolean values from yes/no to true/false - Improve task names with proper capitalization and clarity - Replace ansible.builtin.shell with ansible.builtin.command for oc commands - Replace mv command with ansible.builtin.copy module using remote_src - Add retry logic (5 retries, 5s delay) to observability operator wait task - Fix OCP inventory structure to use .json consistently for local and remote sources - Add explicit cmd parameter to all command/shell tasks - Add mode and become flags where appropriate This ensures consistency, better error handling, and alignment with Ansible best practices for module usage and task naming conventions. AI Model: Generated using Auto (agent router designed by Cursor)
cjeanner
force-pushed
the
refactor/bootstrap
branch
from
0bd9800 to
c89604a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures consistency, better error handling, and alignment with Ansible best practices for module usage and task naming conventions.
AI Model: Generated using Auto (agent router designed by Cursor)