Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase upstream code #307

Closed
wants to merge 108 commits into from
Closed

Rebase upstream code #307

wants to merge 108 commits into from

Conversation

mukrishn
Copy link

Description

Rebased code from upstream, pulled this commit out of #303

Fixes # (issue)

Type of change

Please select the appropriate options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Versions:
  • Hardware:

Checklist

  • I have performed a self-review of my own code
  • If a change is adding a feature, it should require a change to the README.md and the review should catch this.
  • If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
  • A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
  • PRs should not be merged unless positively reviewed.

dependabot bot and others added 30 commits November 3, 2021 12:10
@dependabot
build(deps): bump actions/checkout from 2.3.4 to 2.4.0 (openshift-kni…
edca583 
…#812)

Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.4...v2.4.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): update ansible requirement from <4.7.0 to <4.9.0 (opensh…
c08a5a9 
…ift-kni#813)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump technote-space/broken-link-checker-action
3693549 
Bumps [technote-space/broken-link-checker-action](https://github.com/technote-space/broken-link-checker-action) from 2.2.9 to 2.2.10.
- [Release notes](https://github.com/technote-space/broken-link-checker-action/releases)
- [Changelog](https://github.com/technote-space/broken-link-checker-action/blob/main/.releasegarc)
- [Commits](technote-space/broken-link-checker-action@v2.2.9...v2.2.10)

---
updated-dependencies:
- dependency-name: technote-space/broken-link-checker-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@iranzo
Merge pull request openshift-kni#814 from openshift-kni/dependabot/gi…
b6b9180 
…thub_actions/technote-space/broken-link-checker-action-2.2.10
@dependabot
build(deps): bump actions/setup-python from 2.2.2 to 2.3.0
b4ab28a 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2.2.2 to 2.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2.2.2...v2.3.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@iranzo
Merge pull request openshift-kni#815 from openshift-kni/dependabot/gi…
9792a5c 
…thub_actions/actions/setup-python-2.3.0
@dependabot
build(deps): bump actions/cache from 2.1.6 to 2.1.7
9197bb6 
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@iranzo
Merge pull request openshift-kni#816 from openshift-kni/dependabot/gi…
876eced 
…thub_actions/actions/cache-2.1.7
@dependabot
build(deps): update ansible requirement from <4.9.0 to <4.10.0 (opens…
f01363c 
…hift-kni#817)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump actions/setup-python from 2.3.0 to 2.3.1
9c750b0 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2.3.0...v2.3.1)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@iranzo
Merge pull request openshift-kni#818 from openshift-kni/dependabot/gi…
eea2ec6 
…thub_actions/actions/setup-python-2.3.1
@dependabot
build(deps): update ansible requirement from <4.10.0 to <5.1.0 (opens…
8e5b2e9 
…hift-kni#819)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): update ansible requirement from <5.1.0 to <5.2.0 (opensh…
d6cbacf 
…ift-kni#821)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rabin-io
Update install-config.j2 template to support provisioningDHCPRange
1b3de29 
Allow to set the provisioningDHCPRange if the prov_dhcp_range variable is set
@derekhiggins
Add derekhiggins as an approver
12a8652 
The previous owners of this repository have moved
onto other things, I'll will be keeping things operating
until more permanent owners are identified.
@rlopez133
Merge pull request openshift-kni#828 from derekhiggins/update-owners
f577033 
Add derekhiggins as an approver
@jlojosnegros
Update OWNERS_ALIASES (openshift-kni#820)
1f06c99
@dependabot
build(deps): bump technote-space/broken-link-checker-action (openshif…
146d2ec 
…t-kni#825)

Bumps [technote-space/broken-link-checker-action](https://github.com/technote-space/broken-link-checker-action) from 2.2.10 to 2.2.11.
- [Release notes](https://github.com/technote-space/broken-link-checker-action/releases)
- [Changelog](https://github.com/technote-space/broken-link-checker-action/blob/main/.releasegarc)
- [Commits](technote-space/broken-link-checker-action@v2.2.10...v2.2.11)

---
updated-dependencies:
- dependency-name: technote-space/broken-link-checker-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): update ansible requirement from <5.2.0 to <5.3.0 (opensh…
dbc6ced 
…ift-kni#827)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@patrickeasters
Add defaults for async deployment timeouts (openshift-kni#809)
4410400 
Set defaults for increase_bootstrap_timeout and increase_install_timeout
vars
@dependabot
build(deps): bump technote-space/broken-link-checker-action (openshif…
71ab87c 
…t-kni#829)

Bumps [technote-space/broken-link-checker-action](https://github.com/technote-space/broken-link-checker-action) from 2.2.11 to 2.2.12.
- [Release notes](https://github.com/technote-space/broken-link-checker-action/releases)
- [Changelog](https://github.com/technote-space/broken-link-checker-action/blob/main/.releasegarc)
- [Commits](technote-space/broken-link-checker-action@v2.2.11...v2.2.12)

---
updated-dependencies:
- dependency-name: technote-space/broken-link-checker-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@p3ck
Add Optional support for irmc BMC (openshift-kni#826)
3f89e55 
This allows for irmc BMC to be used in the install-config.yaml.
@tonyskapunk
Use rhcos json stream on 4.8+ (openshift-kni#831)
85b2abd 
* Use openshift-baremetal-install coreos print-stream-json to obtain RHCOS image paths

- Starting in 4.8 the installer contains pinned images of RHCOS in the binary
- Format of the stream is different so its parsing differs to older versions

* Use correct conditional on rhcos facts

* Use proper rhcos key
@dollierp
Add Optional support for FIPS enabled clusters (openshift-kni#841)
30e234b 
Signed-off-by: Denis Ollier <dollierp@redhat.com>
@dependabot
build(deps): bump technote-space/broken-link-checker-action
02694c2 
Bumps [technote-space/broken-link-checker-action](https://github.com/technote-space/broken-link-checker-action) from 2.2.12 to 2.3.1.
- [Release notes](https://github.com/technote-space/broken-link-checker-action/releases)
- [Changelog](https://github.com/technote-space/broken-link-checker-action/blob/main/.releasegarc)
- [Commits](technote-space/broken-link-checker-action@v2.2.12...v2.3.1)

---
updated-dependencies:
- dependency-name: technote-space/broken-link-checker-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump actions/stale from 4 to 6
1cc1bdf 
Bumps [actions/stale](https://github.com/actions/stale) from 4 to 6.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v4...v6)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump actions/cache from 2.1.7 to 3.0.11
b8585c1 
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.7 to 3.0.11.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v2.1.7...v3.0.11)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@abhatt-rh
Remove reference to openstack baremetal and update it to baremetal
9aa4f4a
@derekhiggins
Merge pull request openshift-kni#908 from abhatt-rh/bz-1937458
5f6c7f0 
BZ-1937458: Remove reference to openstack baremetal and update it to baremetal
@derekhiggins
Merge pull request openshift-kni#822 from rabin-io/provisioningDHCPRange
4078370 
Update install-config.j2 template to support provisioningDHCPRange
dependabot bot and others added 23 commits April 18, 2023 14:19
@dependabot @fredericlepied
build(deps): update ansible requirement from <7.4.0 to <7.5.0
081c3e2 
Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@rabin-io
Add support for wwnVendorExtension & wwnWithExtension as disk hints (o…
7ffc922 
…penshift-kni#960)

* Add wwnVendorExtension, wwnWithExtension

to roothint_list

* Update install-config templates

Add quotes around disk hint value,
in case the value in format of "0x1234"
which Ansible will convert to integer

Signed-off-by: Rabin Yasharzadehe <rabin@rabin.io>

---------

Signed-off-by: Rabin Yasharzadehe <rabin@rabin.io>
@rabin-io
Add missing quotes for drive hint in workers group (openshift-kni#961)
ed57607
@dependabot @fredericlepied
build(deps): bump actions/setup-python from 4.5.0 to 4.6.0
38b504c 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4.5.0...v4.6.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @fredericlepied
build(deps): update ansible requirement from <7.5.0 to <7.6.0
4308a35 
Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @fredericlepied
build(deps): update ansible requirement from <7.6.0 to <7.7.0
e84385c 
Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @fredericlepied
build(deps): bump actions/setup-python from 4.6.0 to 4.6.1
a7a18df 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4.6.0...v4.6.1)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@tonyskapunk
Introduce the use of imageDigestSources (openshift-kni#965)
247ad81 
The imageContentSources is being deprecated in the openshift-installer
and imageDigestSources is replacing it.
Allow the use of imageDigestSources when the disconnected registry is created.
Updating docs to reflect the use of each CR depending on the OCP version
@dependabot @fredericlepied
build(deps): bump actions/checkout from 3.5.2 to 3.5.3
ef54d0d 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.5.2...v3.5.3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@tonyskapunk
Add externalMACAddress in virtualmedia template (openshift-kni#974)
ac4c196 
Bringing parity with non-virtualmedia installs by adding
externalMACAddress in the virtualmedia template, allowing
libvirt to use a specific hwaddr in the provisioner host.
Limiting the use of provisioningHostIP in virtualmedia only
in the supported (4.6) version

Signed-off-by: Tony Garcia <tonyg@redhat.com>
@fdaencarrh
Change the RHCOS image cache container public registry (openshift-kni…
bcd2038 
…#978)

* Change the RHCOS image cache container

registry.centos.org seems to be done or unavailable.
Changing from registry.centos.org to quay.io and add the ability
to change it if needed.

* Change registry.centos.org in the documentation

Change the documentation to replace registry.centos.org to quay.io
@nsilla
Allowing status code 301 when verifying the internet connectivity (op…
05eb4de 
…enshift-kni#986)

Currently, when checking the connectivity to the Internet, an HTTP query
is set against https://www.redhat.com.

This address will respond with a 301 status code redirecting the client
to https://www.redhat.com/en.

The URI ansible module is able to follow redirects so, if everything is
OK, the query shour result in either a 200 status code if the server is
reachable, or a -1 if it's not. In this later scenario, a disconnected
environment is assumed.

The problem is in some labs the web server gets into an infinite
redirect loop, so the resulting status code would be 301.

This change allows for this status code to be accepted as evidence that
the Red Hat web site was reached and, therefore, the network has
Internet access.
@nsilla @derekhiggins
Added support for redfish for KVM hosts
861807d 
Currently redfish is supported for HP and Dell systems, but none of
these vendors provide settings compatible with sushy-tools based virtual
BMCs. For instance, all the KVMs in the same hypervisor share the BMC
address, and are differentiated by the system ID, which is part of the
resource path.

This change extends the install-config and install-config-virtualmedia
templates to allow for sushy-tools based redfish vBMCs.
@fdaencarrh
Fix task Get URL of host providing the webserver (openshift-kni#988)
d0c45de 
Fix the issue "'in <string>' requires string as left operand, not int"
at the task "Get URL of host providing the webserver"
@tonyskapunk
Rename node-prep role to node_prep (openshift-kni#987)
55aa682 
* Rename node-prep role to node_prep

This role among install is expected to be moved to ansible collections.
Ansible collections requires that roles include only underscores, i.e.
hyphens are not allowed

* Keep a symlink to the old repo name
@zhouhao3
install-config.j2: support disableCertificateVerification for irmc (o…
6efddca 
…penshift-kni#983)

Signed-off-by: Zhou Hao <zhouhao@fujitsu.com>
@tonyskapunk
Use collections (openshift-kni#1000)
d433c3f 
* Use collections

Move to use collections, this is to conclude the migration of roles to
the redhatci.ocp collection.
Add the steps and changes required to consume collections.
Remove the submodule for containers.podman and use a newer version.
Update the docs to make clear the playbook is using collections.

* Install collection dependency in GH workflow
@mukrishn
rebase from upstream
fb0feb1
@mukrishn
updated playbook to use collections
4751785
@mukrishn
fixing playbook
a0eea80
@mukrishn
reading collection path custom ign file
7d40ad8
@mukrishn
r640 servers shift to rack f18
f858dc0
@mukrishn
custom network config was not set
2a2d055
@mukrishn mukrishn mentioned this pull request Apr 22, 2024
Merged
12 tasks
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@mukrishn
Copy link
Author

#303 already got it rebased

@mukrishn mukrishn closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecastillolema josecastillolema Awaiting requested review from josecastillolema

Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.