use new package_tool for autohpl's openblas #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayalibhavsar
force-pushed
the
autohpl_pkg
branch
3 times, most recently
from
9662bf2 to
facc041
Compare
sayalibhavsar
force-pushed
the
autohpl_pkg
branch
from
facc041 to
a2025fc
Compare
- Update openblas_packages.json to use FlexiBLAS packages for RHEL 10
(flexiblas, flexiblas-devel, flexiblas-openblas-openmp)
- Fix check_mpi() to handle RHEL 10's direct PATH installation
(RHEL 10 doesn't use environment modules for MPI)
- Add zip/unzip packages to general_packages.json for all distros
(required by save_results script)
Tested on RHEL 10 with --regression flag.
- Fix OS ID from 'amazon' to 'amzn' to match detect_os output
- Add version detection logic to skip OpenBLAS package install for AL2
(AL2 compiles OpenBLAS from source, AL2023 uses packages)
Tested on:
- Amazon Linux 2 (compiles OpenBLAS from source)
- Amazon Linux 2023 (uses packages)
- fix OpenBLAS typo in the base Makefile - add a SLES-specific Makefile with correct MPI and OpenBLAS paths - update size_platform() for SLES on x86_64 and aarch64 - have build_hpl() to detect and use the SLES Makefile
- Added RHEL 10-specific makefiles using FlexiBLAS (libopenblaso.so.0) - Added RHEL 10 MPI PATH and LD_LIBRARY_PATH setup for build and runtime - Support for both ARM (aarch64) and x86_64 (Intel/AMD) architectures - Tested on m6g.2xlarge (Graviton2 ARM)
Contributor
Author
|
https://docs.google.com/document/d/106sEgjusKeyZpAGA48lAd77iKx0coh_HATkMIKADL5w/edit?tab=t.0 |
sayalibhavsar
force-pushed
the
autohpl_pkg
branch
from
3740b28 to
2eb1b4f
Compare
sayalibhavsar
force-pushed
the
autohpl_pkg
branch
from
2eb1b4f to
b3179fd
Compare
sayalibhavsar
force-pushed
the
autohpl_pkg
branch
from
cd1d8de to
f9f35a9
Compare
sayalibhavsar
force-pushed
the
autohpl_pkg
branch
3 times, most recently
from
7757e76 to
f9f35a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces centralized JSON files for package dependencies in wrappers. Common packages (compilers, build tools, MPI) are defined in
general_packages.json, and library-specific ones (e.g., OpenBLAS) inopenblas_packages.json. Thebuild_run_hpl.shscript now uses these files to streamline and deduplicate package installation.Before vs After
Before: Duplicate inline
package_toolcalls for each package; dependencies like gcc, git, make, and wget required manual or repeated installation.After: Unified
package_toolcall using JSON configs; common and library-specific dependencies(mkl, blis) are handled cleanly without repetition.Notes
Standardizes package management across wrappers for RHEL, Ubuntu, and Amazon Linux.
JIRA: [RPOPC-689](https://issues.redhat.com/browse/RPOPC-689)