Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable source-git automation #80

Merged
merged 1 commit into from
Jul 17, 2024
Merged

ci: enable source-git automation #80

merged 1 commit into from
Jul 17, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Feb 12, 2024

  • commit validation
  • pull request validation
  • tracker validation
  • automatic merging

rhel-only

@jamacku jamacku marked this pull request as ready for review February 13, 2024 09:20
@jamacku jamacku requested a review from pvalena February 13, 2024 09:21
@jamacku
Copy link
Member Author

jamacku commented Feb 13, 2024

@pvalena It's ready for your review.

Is there some JIRA issue I could reference?

@pvalena
Copy link
Contributor

pvalena commented Jul 16, 2024

@pvalena It's ready for your review.

Is there some JIRA issue I could reference?

https://issues.redhat.com/browse/RHEL-30581

Thanks for working on this! What are the conditions of automatic merging?

@jamacku
ci: enable source-git automation
16a46f3 
- commit validation
- pull request validation
- tracker validation
- automatic merging

rhel-only

Related: RHEL-30581
@jamacku
Copy link
Member Author

jamacku commented Jul 16, 2024

Thanks for working on this! What are the conditions of automatic merging?

  1. Each commit has to reference dracut JIRA
  2. Each commit has to reference the upstream commit or has to be marked as rhel-only
  3. All CI checks have to pass, or the ci-waived label has to be set
  4. Positive Review from org member
  5. No WIP or draft

But you will be guided by comments like this: redhat-plumbers/systemd-rhel10#12 (comment)

@pvalena
Copy link
Contributor

pvalena commented Jul 17, 2024

That's great!
Thanks!

@pvalena pvalena merged commit c8bc806 into redhat-plumbers:main Jul 17, 2024
42 of 44 checks passed
@jamacku jamacku deleted the source-git-auto branch July 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvalena pvalena pvalena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamacku @pvalena