(#2215925) When Delegate=yes is set for a unit, run ExecStartPre= and friends in a subcgroup of the unit #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracker - 2215925 The following commits meet all requirements
|
systemd-rhel-bot
changed the title
|
@dtardon CentOS CI is very unhappy, in results I see failures all over the place and but I am not sure if they can be attributed to this change. Can you please force push to retrigger the CI? |
…nds in a subcgroup of the unit Otherwise we might conflict with the "no-processes-in-inner-cgroup" rule of cgroupsv2. Consider nspawn starting up and initializing its cgroup hierarchy with "supervisor/" and "payload/" as subcgroup, with itself moved into the former and the payload into the latter. Now, if an ExecStartPre= is run right after it cannot be placed in the main cgroup, because that is now in inner cgroup with populated children. Hence, let's run these helpers in another sub-cgroup .control/ below it. This is somewhat ugly since it weakens the clear separation of ownership, but given that this is an explicit contract, and double opt-in should be acceptable. Fixes: #10482 (cherry picked from commit 78f9320) Resolves: #2215925
(cherry picked from commit 077c40b) Related: #2215925
dtardon
force-pushed
the
bz2215925-Delegate+ExecStopPost
branch
from
adea707
to
2fc2acc
Compare
|
The fail is not related to this PR, I've seen it in other PRs as well. I'll try to figure out what's going on. |
systemd-rhel-bot
changed the title
systemd-rhel-bot
changed the title
dtardon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2215925