Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(RHEL-5991) Do not assign badness to filtered-out syscalls #399

Merged
merged 3 commits into from
Jan 22, 2024
Merged

(RHEL-5991) Do not assign badness to filtered-out syscalls #399

merged 3 commits into from
Jan 22, 2024

Commits on Jan 22, 2024

  1. analyze security: fix recursive call of syscall_names_in_filter() 

    When `syscall_names_in_filter()` is called in itself, it is already
examined with `whitelist`. Or, in other words, `syscall_names_in_filter()`
returns bad or good in boolean. So, the returned value should not be
compared with `whitelist` again.

This replaces #11302.

(cherry picked from commit 95832a0)

Related: RHEL-5991
    @yuwata @dtardon
    yuwata authored and dtardon committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    785a8e9 View commit details
    Browse the repository at this point in the history

  2. analyze-security: do not assign badness to filtered-out syscalls 

    Fixes #16451, https://bugzilla.redhat.com/show_bug.cgi?id=1856273.

(cherry picked from commit 01ecb36)

Resolves: RHEL-5991
    @keszybz @dtardon
    keszybz authored and dtardon committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    af05507 View commit details
    Browse the repository at this point in the history

  3. analyze-security: include an actual syscall name in the message 

    This information was already available in the debug output, but I think it
is good to include it in the message in the table. This makes it easier to wrap
one's head around the allowlist/denylist filtering.

(cherry picked from commit a9134af)

Related: RHEL-5991
    @keszybz @dtardon
    keszybz authored and dtardon committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ec483af View commit details
    Browse the repository at this point in the history