(RHEL-6210) cryptsetup: try to detach the device multiple times before giving up #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
github-actions
bot
added
tracker/unapproved
Commit validationTracker - RHEL-6210 The following commits meet all requirements
Tracker validationFailed🔴 Tracker RHEL-6210 has not been approved Success🟢 Tracker RHEL-6210 has set desired product: Pull Request validationFailed🔴 Failed or pending statuses - |
|
Marking as a draft so it is not automatically merge. Maybe we will be able to backport blockdev@.target |
Terrible hack for RHEL8. We are missing the blockdev@.target, so we can't correctly express some dependencies. That means when systemd-cryptsetup detach can fail, because for example a filesystem is still mounted on top of the device. This can cause shutdown to hang forever. See https://issues.redhat.com/browse/RHEL-6210 So as a workaround, let's try to detach the device multiple times before giving up. Proper fix is systemd/systemd@44b0d1f RHEL-only Resolves: RHEL-6210
|
Hmm with encrypted root, there is now 10 seconds delay in shutdown every time 😿 |
|
Replaced by #429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terrible hack for RHEL8. We are missing the blockdev@.target, so we can't correctly express some dependencies. That means when systemd-cryptsetup detach can fail, because for example a filesystem is still mounted on top of the device. This can cause shutdown to hang forever. See https://issues.redhat.com/browse/RHEL-6210 So as a workaround, let's try to detach the device multiple times before giving up. */
RHEL-only
Resolves: RHEL-6210