-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(RHEL-28048) pam: add call to pam_umask #435
(RHEL-28048) pam: add call to pam_umask #435
Conversation
…nager This patch changes the way user managers set the default umask for the units it manages. Indeed one can expect that if user manager's umask is redefined through PAM (via /etc/login.defs or pam_umask), all its children including the units it spawns have their umask set to the new value. Hence make user units inherit their umask value from their parent instead of the hard coded value 0022 but allow them to override this value via their unit file. Note that reexecuting managers with 'systemctl daemon-reexec' after changing UMask= has no effect. To take effect managers need to be restarted with 'systemct restart' instead. This behavior was already present before this patch. Fixes #6077. (cherry picked from commit 5e37d19) Related: RHEL-28048
Setting umask for user sessions via UMASK setting in /etc/login.defs is a well-known feature. Let's make sure that user manager also runs with this umask value. Follow-up for 5e37d19. (cherry picked from commit 159f1b78576ce91c3932f4867f07361a530875d3) Resolves: RHEL-28048
Commit validationTracker - RHEL-28048 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-28048 has set desired product: Pull Request validationSuccess🟡 CI - Waived Auto MergeFailed🔴 Pull Request has unsupported target branch Success🟢 Pull Request is not marked as draft and it's not blocked by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mrc0mmand I assume that CI failure is unrelated to the changes according to |
Yeah, that's unrelated. I'll try to look into that and work around it (somehow). |
Setting umask for user sessions via UMASK setting in /etc/login.defs is
a well-known feature. Let's make sure that user manager also runs with
this umask value.
Follow-up for 5e37d19.
(cherry picked from commit 159f1b78576ce91c3932f4867f07361a530875d3)
Resolves: RHEL-28048