Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-11040) udev: raise RLIMIT_NOFILE as high as we can #204

Merged

Conversation

dtardon
Copy link
Member

@dtardon dtardon commented Oct 26, 2023

We might need a lot of fds on large systems, hence raise RLIMIT_NOFILE to what the service manager allows us, which is quite a lot these days.

udev already sets FORK_RLIMIT_NOFILE_SAFE when forking of chilren, thus ensuring that forked off processes get their RLIMIT_NOFILE soft limit reset to 1K for compat with crappy old select().

Replaces: #29298
Fixes: #28583
(cherry picked from commit 1617424)

Resolves: RHEL-11040

We might need a lot of fds on large systems, hence raise RLIMIT_NOFILE
to what the service manager allows us, which is quite a lot these days.

udev already sets FORK_RLIMIT_NOFILE_SAFE when forking of chilren, thus
ensuring that forked off processes get their RLIMIT_NOFILE soft limit
reset to 1K for compat with crappy old select().

Replaces: #29298
Fixes: #28583
(cherry picked from commit 1617424)

Resolves: RHEL-11040
@github-actions github-actions bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Oct 26, 2023
@github-actions
Copy link

Tracker - RHEL-11040

The following commits meet all requirements

commit upstream
08d10fe - udev: raise RLIMIT_NOFILE as high as we can systemd/systemd@1617424

@github-actions github-actions bot added tracker/missing Formerly needs-bz and removed pr/needs-ci Formerly needs-ci labels Oct 26, 2023
@github-actions github-actions bot removed the tracker/missing Formerly needs-bz label Nov 8, 2023
@github-actions github-actions bot changed the title udev: raise RLIMIT_NOFILE as high as we can (RHEL-11040) udev: raise RLIMIT_NOFILE as high as we can Nov 8, 2023
Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the pr/needs-review Formerly needs-review label Nov 13, 2023
@jamacku jamacku merged commit 5221eda into redhat-plumbers:main Nov 13, 2023
@dtardon dtardon deleted the RHEL-11040-udevd-RLIMIT_NOFILE branch November 13, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants