(RHEL-16354) UKI support in kernel-install #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the kernel-install man page only documents the bls layout for use with the boot loader spec type redhat-plumbers#1. 90-loaderentry.install uses this layout to generate loader entries and copy the kernel image and initrd to $BOOT. This commit documents a second layout "uki" and adds 90-uki-copy.install, which copies a UKI "uki.efi" from the staging area or any file with the .efi extension given on the command line to $BOOT/EFI/Linux/$ENTRY_TOKEN-$KERNEl_VERSION(+$TRIES).efi This allows for both locally generated and distro-provided UKIs to be handled by kernel-install. (cherry picked from commit 0ccfd35) Resolves: RHEL-16354
(cherry picked from commit 642617f) Related: RHEL-16354
|
Tracker - RHEL-16354 The following commits meet all requirements
|
github-actions
bot
added
pr/needs-ci
jamacku
previously requested changes
Nov 23, 2023
There was a problem hiding this comment.
@keszybz Please update commit message of commit - 506ff04- kernel-install: handle uki installs automatically.
Please replace Resolves: #25822 with Resolves: https://github.com/systemd/systemd/issues/25822.
Resolves: # is a keyword used in RHEL to reference Bugzilla bugs. And since we don't allow multiple trackers in one PR, our automation is failing.
github-actions
bot
added
pr/changes-requested
and removed
pr/needs-review
Detect image type using "bootctl kernel-identify $kernel", store result in KERNEL_INSTALL_IMAGE_TYPE. Extend layout autodetection to check the kernel image type and pick layout=uki for UKIs. Resolves: systemd/systemd#25822 (cherry picked from commit 3d5f0bf) Related: RHEL-16354
Do not consider a missing 'Linux' subdirectory an error. Just create it instead. (cherry picked from commit c7314ee) Related: RHEL-16354
Let's log where we install a UKI when running in verbose mode. (cherry picked from commit 4f5278e) Related: RHEL-16354
(cherry picked from commit e425849) Related: RHEL-16354
The command takes a kernel as argument and checks what kind of kernel the image is. Returns one of uki, pe or unknown. (cherry picked from commit 53c368d) Resolves: RHEL-16354
Takes a kernel image as argument. Prints details about the kernel. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> (cherry picked from commit a052559) Resolves: RHEL-16354
(cherry picked from commit 24a3b37) Related: RHEL-16354
We never do that, don't do so here either. (cherry picked from commit 2b19796) Related: RHEL-16354
Let's call them kernel *images*, not just *kernels*. (cherry picked from commit 1e7d6cc) Related: RHEL-16354
(cherry picked from commit e684d2d) Related: RHEL-16354
(cherry picked from commit 2d42604) Related: RHEL-16354
Mostly follow-ups for #26082. (cherry picked from commit 5b532e1) Related: RHEL-16354
(cherry picked from commit 02b7005) Related: RHEL-16354
Follow-ups for #26124 and #26158. - use os_release_pretty_name(), - constify the buffer passed to inspect_osrel(), - propagate errors in inspect_osrele(), and ignore them in the caller side, - and several coding style fixlets. (cherry picked from commit 1b7586d) Related: RHEL-16354
(cherry picked from commit 3b42ffe) Related: RHEL-16354
Read the magic first, try reading the full DOS exe header only in case the magic check succeeds. This avoids throwing an header read error on small dummy files as used by test-kernel-install. (cherry picked from commit 78088b8) Related: RHEL-16354
keszybz
force-pushed
the
rhel-9.4.0-kernel-install-uki
branch
from
8d61527 to
458d84a
Compare
github-actions
bot
changed the title
github-actions
bot
added
pr/needs-ci
github-actions
bot
added
pr/needs-review
|
Btw, bootctl pieces weren't strictly needed (I think) as we don't really use systemd-boot in RHEL but I guess it doesn't hurt to have them in as bootctl is useful to some extent even without systemd-boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.