-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(RHEL-5988) udevadm trigger --settle
follow-ups
#216
Merged
github-actions
merged 5 commits into
redhat-plumbers:main
from
mrc0mmand:udevadm-trigger-settle-followups
Dec 11, 2023
Merged
(RHEL-5988) udevadm trigger --settle
follow-ups
#216
github-actions
merged 5 commits into
redhat-plumbers:main
from
mrc0mmand:udevadm-trigger-settle-followups
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/needs-ci
Formerly needs-ci
pr/needs-review
Formerly needs-review
labels
Dec 11, 2023
Tracker - RHEL-5988 The following commits meet all requirements
|
github-actions
bot
changed the title
(RHEL-5988) Dec 11, 2023
udevadm trigger --settle
follow-upsudevadm trigger --settle
follow-ups
mrc0mmand
force-pushed
the
udevadm-trigger-settle-followups
branch
2 times, most recently
from
December 11, 2023 11:32
27a4742
to
5b70ef0
Compare
The last commit is from #215 to make the build pass, once that PR is merged I'll rebase this one. |
(cherry picked from commit 3e61656) Related: RHEL-5988
…time If a device is successfully triggered with synthetic UUID, then that means the kernel support it. Hence, it is not necessary to fallback without UUID for later devices. (cherry picked from commit b150394) Related: RHEL-5988
If the kernel support synthetic UUID in uevent, then let's assume that the UUID is unique, and check only if the received UUID matches we specified. Partially fixes #25115. (cherry picked from commit dfbd824) Related: RHEL-5988
…named For older kernels that synthetic UUID is not supported, we need to also check the original device name, as udevd broadcasts uevent with new sysname. Fixes #25115. (cherry picked from commit 1193448) Related: RHEL-5988
(cherry picked from commit ff4d2a0) Related: RHEL-5988
mrc0mmand
force-pushed
the
udevadm-trigger-settle-followups
branch
from
December 11, 2023 12:25
5b70ef0
to
3027bcc
Compare
msekletar
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
removed
pr/needs-review
Formerly needs-review
pr/needs-ci
Formerly needs-ci
labels
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #191 (comment) where
udevadm trigger --settle
freezes when used with an about-to-be-renamed device, see systemd/systemd#25115.