Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-5988) udevadm trigger --settle follow-ups #216

Merged

Conversation

mrc0mmand
Copy link
Member

@mrc0mmand mrc0mmand commented Dec 11, 2023

Addresses #191 (comment) where udevadm trigger --settle freezes when used with an about-to-be-renamed device, see systemd/systemd#25115.

Copy link

github-actions bot commented Dec 11, 2023

Tracker - RHEL-5988

The following commits meet all requirements

commit upstream
0893a55 - sd-id128: introduce id128_hash_ops_free systemd/systemd@3e61656
e802b63 - udevadm-trigger: allow to fallback without synthetic UUID only first t… systemd/systemd@b150394
3fea03b - udevadm-trigger: settle with synthetic UUID if the kernel support it systemd/systemd@dfbd824
fdf2ba6 - udevadm-trigger: also check with the original syspath if device is ren… systemd/systemd@1193448
3027bcc - test: use 'udevadm trigger --settle' even if device is renamed systemd/systemd@ff4d2a0

@github-actions github-actions bot changed the title udevadm trigger --settle follow-ups (RHEL-5988) udevadm trigger --settle follow-ups Dec 11, 2023
@mrc0mmand mrc0mmand force-pushed the udevadm-trigger-settle-followups branch 2 times, most recently from 27a4742 to 5b70ef0 Compare December 11, 2023 11:32
@mrc0mmand
Copy link
Member Author

The last commit is from #215 to make the build pass, once that PR is merged I'll rebase this one.

@github-actions github-actions bot added the tracker/missing Formerly needs-bz label Dec 11, 2023
(cherry picked from commit 3e61656)

Related: RHEL-5988
…time

If a device is successfully triggered with synthetic UUID, then that means
the kernel support it. Hence, it is not necessary to fallback without UUID
for later devices.

(cherry picked from commit b150394)

Related: RHEL-5988
If the kernel support synthetic UUID in uevent, then let's assume that
the UUID is unique, and check only if the received UUID matches we
specified.

Partially fixes #25115.

(cherry picked from commit dfbd824)

Related: RHEL-5988
…named

For older kernels that synthetic UUID is not supported, we need to also
check the original device name, as udevd broadcasts uevent with new
sysname.

Fixes #25115.

(cherry picked from commit 1193448)

Related: RHEL-5988
(cherry picked from commit ff4d2a0)

Related: RHEL-5988
@mrc0mmand mrc0mmand force-pushed the udevadm-trigger-settle-followups branch from 5b70ef0 to 3027bcc Compare December 11, 2023 12:25
@github-actions github-actions bot removed the tracker/missing Formerly needs-bz label Dec 11, 2023
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamacku jamacku added this to the RHEL-9.4.0 milestone Dec 11, 2023
@github-actions github-actions bot removed pr/needs-review Formerly needs-review pr/needs-ci Formerly needs-ci labels Dec 11, 2023
@github-actions github-actions bot merged commit ff755f0 into redhat-plumbers:main Dec 11, 2023
31 checks passed
@mrc0mmand mrc0mmand deleted the udevadm-trigger-settle-followups branch December 11, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants