Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-20757) Fixlets for StopIdleSessionSec= logic regarding greeter and background sessions #222

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

msekletar
Copy link
Member

@msekletar msekletar commented Jan 5, 2024

No description provided.

msekletar and others added 2 commits January 5, 2024 17:51
Reason to skip the idle session logic for these session classes is that
they are idle by default.

(cherry picked from commit 508b478)

Related: RHEL-20757
If we allow the timer accuracy to grow larger then the timeout itself
things are very confusing, because people might set a 1s time-out and we
turn that into 30s.

Hence, let's just cut off the 30s accuracy to the time-out itself, so
that we stay close to what users configured.

(cherry picked from commit e20bfa5)

Related: RHEL-20757
@github-actions github-actions bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

Tracker - RHEL-20757

The following commits meet all requirements

commit upstream
8b0b18e - logind: don't setup idle session watch for lock-screen and greeter systemd/systemd@508b478
eadfad2 - logind: don't make idle action timer accuracy more coarse than timeout… systemd/systemd@e20bfa5
a88f58f - logind: do TTY idle logic only for sessions marked as "tty" systemd/systemd@20604ff

@github-actions github-actions bot added the tracker/unapproved Formerly needs-acks label Jan 5, 2024
Otherwise things might be weird, because background sessions might
become "idle", wich doesn#t really make much sense.

This shouldn't change much in 99% of the cases, but slightly corrects
behaviour as it ensures only "primary"/"foreground" sessions get the
idle logic, i.e. where a user exists that could actually make it
non-idle.

(cherry picked from commit 20604ff)

Related: RHEL-20757
@msekletar msekletar force-pushed the idle-ignore-greeter branch from 97341f4 to a88f58f Compare January 5, 2024 17:04
@github-actions github-actions bot removed the pr/needs-ci Formerly needs-ci label Jan 5, 2024
@jamacku jamacku added this to the RHEL-9.4.0 milestone Jan 8, 2024
@github-actions github-actions bot removed the tracker/unapproved Formerly needs-acks label Jan 8, 2024
Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the pr/needs-review Formerly needs-review label Jan 9, 2024
@github-actions github-actions bot merged commit 468acdc into redhat-plumbers:main Jan 9, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants