(RHEL-27383) udev: raise RLIMIT_NOFILE as high as we can #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might need a lot of fds on large systems, hence raise RLIMIT_NOFILE to what the service manager allows us, which is quite a lot these days. udev already sets FORK_RLIMIT_NOFILE_SAFE when forking of chilren, thus ensuring that forked off processes get their RLIMIT_NOFILE soft limit reset to 1K for compat with crappy old select(). Replaces: #29298 Fixes: #28583 (cherry picked from commit 1617424) Resolves: RHEL-27383
github-actions
bot
changed the title
github-actions
bot
added
tracker/invalid-product
pr/needs-ci
Commit validationTracker - RHEL-27383 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-27383 has set desired product: Pull Request validationSuccess🟢 CI - All checks have passed Auto MergeFailed🔴 Pull Request has unsupported target branch Success🟢 Pull Request is not marked as draft and it's not blocked by |
|
Similarly to #240, I slapped on a couple of commits to make the CIs, hopefully, happy. |
mrc0mmand
force-pushed
the
RHEL-27383-udevd-RLIMIT_NOFILE
branch
from
105aa3d to
83e2ee4
Compare
The latest spec contains ukify shenanigans which we don't have in 9.3, making CI sad. Related: RHEL-27383 RHEL-only
In Knot 3.2 the nsec3-iterations default was changed to 0 and Knot now issues a warning if the value is > 0. Let's just use the default value, since it's not something that's important for our tests. (cherry picked from commit 0652cf8) Related: RHEL-27383
knot v3.2 and later does this by default. knot v3.1 still has the default set to 10, but it also introduced a warning that the default will be changed to 0 in later versions, so it effectively complains about its own default, which then fails the config check. Let's just set the value explicitly to zero to avoid that. ~# knotc --version knotc (Knot DNS), version 3.1.6 ~# grep nsec3-iterations test/knot-data/knot.conf || echo nope nope ~# knotc -c /build/test/knot-data/knot.conf conf-check warning: config, policy[auto_rollover_nsec3].nsec3-iterations defaults to 10, since version 3.2 the default becomes 0 Configuration is valid Follow-up to 0652cf8. (cherry picked from commit cb3244c) Related: RHEL-27383
mrc0mmand
force-pushed
the
RHEL-27383-udevd-RLIMIT_NOFILE
branch
from
83e2ee4 to
c051981
Compare
github-actions
bot
added
pr/needs-manual-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might need a lot of fds on large systems, hence raise RLIMIT_NOFILE to what the service manager allows us, which is quite a lot these days.
udev already sets FORK_RLIMIT_NOFILE_SAFE when forking of chilren, thus ensuring that forked off processes get their RLIMIT_NOFILE soft limit reset to 1K for compat with crappy old select().
Replaces: #29298
Fixes: #28583
(cherry picked from commit 1617424)
Resolves: RHEL-27383