(RHEL-16182) units: change assert to condition to skip running in initrd/os #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These units are also present in the initrd, so instead of an assert, just use a condition so they are skipped where they need to be skipped. Fixes systemd/systemd#26358 (cherry picked from commit 7ef09e2) Related: RHEL-16182
github-actions
bot
changed the title
github-actions
bot
added
pr/needs-ci
Commit validationTracker - RHEL-16182 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-16182 has set desired product: Pull Request validationSuccess🟢 CI - All checks have passed Auto MergeSuccess🟢 Pull Request is not marked as draft and it's not blocked by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These units are also present in the initrd, so instead of an assert, just use a condition so they are skipped where they need to be skipped.
Fixes systemd/systemd#26358
(cherry picked from commit 7ef09e2)
Related: RHEL-16182
Noticed this while testing #238. This doesn't affect RHEL 9 directly (yet), since RHEL 9's dracut doesn't pull in these files, but once that change gets backported we'd start seeing fails in journal. Since we're going to do another RHEL 9 build anyway, let's throw this one in as well.