(RHEL-27512) test-execute debug #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHEL-only Resolves: RHEL-27512
When running tests in a container, /sys might not be mounted, so let's make sure we skip tests that depend on /sys in this case. (cherry picked from commit a412a1b) Related: RHEL-27512
(cherry picked from commit 0ce8870) Related: RHEL-27512
- use SD_ID128_STRING_MAX or friend, - use sizeof(sd_id128_t), - use newly introduced ascii_ishex(). (cherry picked from commit 28bf2de) Related: RHEL-27512
…ontents is "uninitialized" Then, this drops ID128_PLAIN_OR_UNINIT. Also, this renames Id128Format -> Id128FormatFlag, and make it bitfield. Fixes #25634. (cherry picked from commit 057bf78) Related: RHEL-27512
(cherry picked from commit 66c7949) Related: RHEL-27512
(cherry picked from commit a237c6e) Related: RHEL-27512
(cherry picked from commit 9be90c4) Related: RHEL-27512
…oc/ is not mounted (cherry picked from commit e272034) Related: RHEL-27512
And drop to mention sd_id128_get_boot_app_specific() may return -ENOENT or -ENOMEDIUM. The function does not read /etc/machine-id. But reads a file in the procfs, which is a kind of the kernel API. Hence the failures are caused only when the system has wrong setup. (cherry picked from commit c576920) Related: RHEL-27512
(cherry picked from commit b40c8eb) Related: RHEL-27512
… an ID is in an invalid format EINVAL suggests that the caller passes an invalid argument. EIO is for "input/output error", i.e. the error you'd get if the disk or file system is borked, and this error code could be returned by the underlying read/write functions. Let's make the functions return an unambiguous error code. (cherry picked from commit e8a6625) Related: RHEL-27512
It may be useful to check if the machine ID or friends is set or not. (cherry picked from commit 786b652) Related: RHEL-27512
(cherry picked from commit 75fa1f2) Related: RHEL-27512
(cherry picked from commit f0d8358) Related: RHEL-27512
This also ensures that the test is skipped when /etc/machine-id exists, but is not initialized. (cherry picked from commit 415eb50) Related: RHEL-27512
…nitialized The part of test_chase_symlink in test-fs-util that calls sd_id128_get_machine will fail if /etc/machine-id is empty, so skip this block if the machine-id is not initialized. (cherry picked from commit 079fcdd) Related: RHEL-27512
(cherry picked from commit a635b62) Related: RHEL-27512
(cherry picked from commit 2c6b738) Related: RHEL-27512
When executed on a systemd with an empty /etc/machine-id, test-journal-interleaving fails in test_sequence_numbers_one() when re-opening the existing "two.journal". This is because opening the existing journal file with managed_journal_file_open() causes journal_file_verify_header() to be called. This function tries to compare the current machine-id to the machine-id in the journal file header, but does not handle the case where the machine-id is empty or non-existent. Check if we have an initialized machine-id before executing this portion of the test. (cherry picked from commit 3a9ca23) Related: RHEL-27512
The journal stuff in RHEL 9 can't handle existing but uninitialized /etc/machine-id and backporting all the necessary changes would mean pulling in another 50+ commits (I stopped after 50, so it's probably much more). And to make matters worse, upstream renamed chase_symlinks*() stuff to chase_*(), which makes the backports even more painful (and risky). Related PRs: - https://github.com/systemd/systemd/pull/25734/commits - https://github.com/systemd/systemd/pull/27137/commits - https://github.com/systemd/systemd/pull/27122/commits RHEL-only Related: RHEL-27512
We have a test where we compare the results from nftw() and our own resurce_dit_at(). nftw() skips a dangling symlink when running under mkosi and the test fails. I don't understand why nftw() does that, but in our code we don't need to test and care about the details of nftw(), which we don't use, outside of the one test, so let's just skip symlinks in the test. Closes #29603. (cherry picked from commit 974959e) Related: RHEL-27512
(cherry picked from commit 31cfcf5) Related: RHEL-27512
If /etc/machine-id contains "uninitialized", specifier_printf() with %m will fail with ENOPKG, so ignore that error as well. (cherry picked from commit 7429c8f) Related: RHEL-27512
The test depends on /sys being writable, so let's skip it when /sys is read-only. (cherry picked from commit 34b5977) Related: RHEL-27512
(cherry picked from commit 4435da1) Related: RHEL-27512
Upstream mkosi sets $KERNEL_INSTALL_BYPASS to 1 by default [0] which then trip over check-help tests, as the message about $KERNEL_INSTALL_BYPASS is not printed out to stderr. Upstream systemd doesn't have this issue, since kernel-install there was rewritten in C, so the code base is completely different. 1068/1073 systemd:dist-check / check-help-kernel-install FAIL 0.02s exit status 4 >>> MALLOC_PERTURB_=212 /work/src/tools/check-help.sh /work/build/kernel-install ――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――― kernel-install with an unknown parameter does not print to stderr ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― [0] systemd/mkosi@deaaa83 RHEL-only Related: RHEL-27512
Before this, tests are split into two categories, system and user, but both are running in fully privileged environment. Hence, unprivileged user scope was mostly not covered by the test. Let's run all tests in both system and user scopes, and drop capabilities when Manager is running in user scope. This also makes the host environment protected more from the test run. (cherry picked from commit 4e032f6) Related: RHEL-27512
If '+' is specified with 'C', let's merge the tree with any existing tree. (cherry picked from commit 1fd5ec5) Related: RHEL-27512
…ary units This function is like `generator_open_unit_file`, but if `ret_temp_path` is passed, a temporary unit is created instead. (cherry picked from commit 8a84e0d) Related: RHEL-27512
…changed When the `systemd-network-generator` is included in the initrd and runs from there first, the next times it runs after switching to real root it thinks there is a duplicate entry on the kernel command line. This patch rewrites the unit file if the content has changed, instead of displaying an error message. (cherry picked from commit f3e4d04) Related: RHEL-27512
It's been a while since we introduced Differential ShellCheck and it proved to be quite useful (and in some ways even better than the shellcheck run by super-linter). So, to have only one linter scream at us for not knowing how to write bash properly, let's drop the super-linter's one in favor of Differential ShellCheck. Follow-up for systemd/systemd#24328 (review) (cherry picked from commit c4b167f) Related: RHEL-27512
- drop Hyperscale SIG repos, so we don't pull in btrfs stuff - use XFS for rootfs - install gnu-efi headers, since RHEL 9 sd-boot still requires it RHEL-only Related: RHEL-27512
Notes:
- on RHEL 9 we don't have vsock support in systemd, so we have to fall
back to some "older" checks (i.e. pre-6aca147f82).
- our systemd-repart doesn't automatically fall back to Format=swap
for Type=swap partitions, so we have to do that explicitely
- don't pull in sd-resolved and sd-networkd, since the former needs
some extra configuration to work alongsideNM, and we don't
build the latter at all on RHEL 9
RHEL-only
Related: RHEL-27512
The automagic enrollment works only with systemd v253 onwards, on v252 we need to do this one extra step. RHEL-only Related: RHEL-27512
github-actions
bot
added
pr/needs-ci
Commit validationTracker - Missing issue tracker ✋ The following commits meet all requirements
The following commits need an inspection
Follow-up detectionFailed🔴 Some follow-up commits for this Pull Request were detected in upstream Follow-ups
Tracker validation🔴 Missing tracker or Unknown tracker type; type: 'unknown' Pull Request validationFailed🔴 Failed or pending checks - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.