Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-31783) execute: Pass AT_FDCWD instead of -1 #253

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

lnykryn
Copy link
Member

@lnykryn lnykryn commented Apr 9, 2024

Let's enforce that callers pass AT_FDCWD as read_dfd to load_credential() to avoid an assert() in read_full_file_full() if read_dfd is -1.

(cherry picked from commit 661e425)

Resolves: RHEL-31783

Let's enforce that callers pass AT_FDCWD as read_dfd to load_credential()
to avoid an assert() in read_full_file_full() if read_dfd is -1.

(cherry picked from commit 661e425)

Resolves: RHEL-31783
@github-actions github-actions bot changed the title execute: Pass AT_FDCWD instead of -1 (RHEL-31783) execute: Pass AT_FDCWD instead of -1 Apr 9, 2024
@github-actions github-actions bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Commit validation

Tracker - RHEL-31783

The following commits meet all requirements

commit upstream
b33fd1c - execute: Pass AT_FDCWD instead of -1 systemd/systemd@661e425

Tracker validation

Success

🟢 Tracker RHEL-31783 has set desired product: rhel-9.3.0
🟢 Tracker RHEL-31783 has set desired component: systemd
🟢 Tracker RHEL-31783 has been approved


Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟢 Pull Request meet requirements, mergeable_state is clean
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

@jamacku jamacku added this to the RHEL-9.5.0 milestone Apr 9, 2024
@jamacku jamacku requested a review from msekletar April 9, 2024 14:31
@github-actions github-actions bot removed the pr/needs-ci Formerly needs-ci label Apr 9, 2024
Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the pr/needs-review Formerly needs-review label Apr 10, 2024
@github-actions github-actions bot merged commit 7d3b9e9 into redhat-plumbers:main Apr 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants