Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-31070) Make journalctl --user -u some.unit work for system users too #255

Merged

Conversation

dtardon
Copy link
Member

@dtardon dtardon commented Apr 9, 2024

No description provided.

As per our usual syntax in the docs.

(cherry picked from commit e754af3)

Related: RHEL-31070
This way we can use it in libsystemd

(cherry picked from commit 8a8b4a8)

Related: RHEL-31070
Let's move this helper call from journald specific code to src/basic/,
so that we can use it from sd-journal.

While we are at it, slightly extend it to also cover container uids,
which are also routed to the system journal now.

This places the call in uid-alloc-range.[ch] which contains similar
functions that match UID ranges for specific purposes.

(cherry picked from commit 115d514)

Related: RHEL-31070
…em UID, imply SD_JOURNAL_SYSTEM

Fixes: #26742 #23679
(cherry picked from commit 97c621b)

Resolves: RHEL-31070
Fixes: #25061
(cherry picked from commit cad8fa4)

Related: RHEL-31070
@dtardon dtardon force-pushed the RHEL-31070-journalctl--user branch from 3c5a1ca to e98d44b Compare April 9, 2024 14:32
@github-actions github-actions bot added tracker/missing Formerly needs-bz pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Commit validation

Tracker - RHEL-31070

The following commits meet all requirements

commit upstream
9fd80d1 - man: suffix --unit with an equal sign, since it expects an argument systemd/systemd@e754af3
06d52b9 - shared: move uid-alloc-range.[ch] from src/shared/ → src/basic/ systemd/systemd@8a8b4a8
e8a2cf2 - journald: move uid_for_system_journal() to uid-alloc-range.h systemd/systemd@115d514
be70144 - sd-journal: when SD_JOURNAL_CURRENT_USER is set, and called from syste… systemd/systemd@97c621b
e98d44b - man: document that journalctl --user requires Storage=persistent systemd/systemd@cad8fa4

Tracker validation

Success

🟢 Tracker RHEL-31070 has set desired product: rhel-9.3.0
🟢 Tracker RHEL-31070 has set desired component: systemd
🟢 Tracker RHEL-31070 has been approved


Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Failed

🔴 Pull Request can't be merged, mergeable is null

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟠 Pull Request doesn't meet requirements, mergeable_state is unknown
🟢 Pull Request has correct target branch main

@github-actions github-actions bot removed the tracker/missing Formerly needs-bz label Apr 9, 2024
@github-actions github-actions bot changed the title Make journalctl --user -u some.unit work for system users too (RHEL-31070) Make journalctl --user -u some.unit work for system users too Apr 9, 2024
@jamacku jamacku added this to the RHEL-9.5.0 milestone Apr 12, 2024
@github-actions github-actions bot removed the pr/needs-review Formerly needs-review label Jun 11, 2024
@github-actions github-actions bot merged commit 6cee9dd into redhat-plumbers:main Jun 11, 2024
29 checks passed
@dtardon dtardon deleted the RHEL-31070-journalctl--user branch June 11, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants