(RHEL-35994) kernel-install: fix uki-copy deinstall #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For "kernel-install remove ..." only the kernel version is passed, not the kernel image. So auto-detecting KERNEL_INSTALL_IMAGE_TYPE and setting KERNEL_INSTALL_LAYOUT does not work for uninstall. The 90-uki-copy.install plugin must consider this and *not* exit early for the "remove" command, otherwise $BOOT_ROOT will be filled with stale kernel images. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> (cherry picked from commit 3037616) Resolves: RHEL-35994
github-actions
bot
added
rhel-9.4.0
pr/needs-ci
Commit validationTracker - RHEL-35994 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-35994 has set desired product: Pull Request validationSuccess🟡 CI - Waived Auto MergeFailed🔴 Pull Request has unsupported target branch Success🟢 Pull Request is not marked as draft and it's not blocked by |
|
Hmm, fuzzing failures are unrelated to changes from PR. |
github-actions
bot
added
pr/needs-manual-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For "kernel-install remove ..." only the kernel version is passed, not the kernel image. So auto-detecting KERNEL_INSTALL_IMAGE_TYPE and setting KERNEL_INSTALL_LAYOUT does not work for uninstall.
The 90-uki-copy.install plugin must consider this and not exit early for the "remove" command, otherwise $BOOT_ROOT will be filled with stale kernel images.
Signed-off-by: Gerd Hoffmann kraxel@redhat.com
(cherry picked from commit 3037616)
Resolves: RHEL-35994