(RHEL-33890) Do not rotate unrelated journal files when full or corrupted #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially when using in-memory logging, these are too noisy so let's drop them back to debug level. (cherry picked from commit afc47ee) Related: RHEL-33890
When we fail to add an entry to a journal file, typically when the file is full or corrupted, it is not necessary to rotate other journal files. Not only that's unnecessary, rotating all journal files allows unprivileged users to wipe system or other user's journals by writing many journal entries to their own user journal file. Let's rotate all journal files only when - it is really requested by a privileged user (e.g. by journalctl --rotate), or - the system time jumps backwards. And, otherwise rotate only the journal file we are currently writing. (cherry picked from commit bd0ec61) Resolves: RHEL-33890
github-actions
bot
changed the title
github-actions
bot
added
tracker/invalid-product
pr/needs-ci
Commit validationTracker - RHEL-33890 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-33890 has set desired product: Pull Request validationSuccess🟢 CI - All checks have passed Auto MergeSuccess🟢 Pull Request is not marked as draft and it's not blocked by |
msekletar
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: RHEL-33890