Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-50103) Revert "udev-builtin-net_id: use firmware_node/sun for ID_NET_NAME_SLOT" #295

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

lnykryn
Copy link
Member

@lnykryn lnykryn commented Aug 22, 2024

This reverts commit 7af151c.

It seems that virtio devices always have "0" in
the firmware_node/sun. And because of that, udev will always name the device ens0, which leads to collisions. So let's disable it for now.

rhel-only: policy

Reverts: RHEL-50103

This reverts commit 7af151c.

It seems that virtio devices always have "0" in
the firmware_node/sun. And because of that, udev will
always name the device ens0, which leads to collisions.
So let's disable it for now.

rhel-only: policy

Reverts: RHEL-50103
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot changed the title Revert "udev-builtin-net_id: use firmware_node/sun for ID_NET_NAME_SLOT" (RHEL-50103) Revert "udev-builtin-net_id: use firmware_node/sun for ID_NET_NAME_SLOT" Aug 22, 2024
@github-actions github-actions bot added the pr/needs-ci Formerly needs-ci label Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Commit validation

Tracker - RHEL-50103

The following commits meet all requirements

commit upstream
9c7e050 - Revert "udev-builtin-net_id: use firmware_node/sun for ID_NET_NAME_SLO… rhel-only: policy

Tracker validation

Success

🟢 Tracker RHEL-50103 has set desired product: rhel-9.5
🟢 Tracker RHEL-50103 has set desired component: systemd
🟢 Tracker RHEL-50103 has been approved


Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟢 Pull Request meet requirements, mergeable_state is clean
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

@github-actions github-actions bot removed the pr/needs-ci Formerly needs-ci label Aug 22, 2024
@github-actions github-actions bot merged commit ae92c09 into redhat-plumbers:main Aug 22, 2024
30 checks passed
@dtardon
Copy link
Member

dtardon commented Jan 15, 2025

By a coincidence, a fix for this issue was proposed--and approved--on the same day: systemd/systemd#34099 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants