(RHEL-50651) Fix detection of TDX confidential VM on Azure platform #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> (cherry picked from commit 129b9e3) Related: RHEL-50651
This helper is a simplified version of detect_confidential_virtualization() that merely returns a boolean status flag reflecting whether we are believed to be running inside a confidential VM. This flag can be used for turning off features that are inappropriate to use from a CVM, but must not be used for releasing sensitive data. The latter must only be done in response to an attestation for the environment. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> (cherry picked from commit b354a2c) Related: RHEL-50651
In a confidential VM, the SMBIOS data is not trusted, as it is under the control of the host OS/admin and not covered by attestation of the machine. Fixes: systemd/systemd#27604 Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> (cherry picked from commit 4b1153c) Related: RHEL-50651
The original CVM detection logic for TDX assumes that the guest can see the standard TDX CPUID leaf. This was true in Azure when this code was originally written, however, current Azure now blocks that leaf in the paravisor. Instead it is required to use the same Azure specific CPUID leaf that is used for SEV-SNP detection, which reports the VM isolation type. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> (cherry picked from commit 9d7be044cad1ae54e344daf8f2ec37da46faf0fd) Related: RHEL-50651
github-actions
bot
changed the title
Commit validationTracker - RHEL-50651 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-50651 has set desired product: Pull Request validationSuccess🟢 CI - All checks have passed Auto MergeSuccess🟢 Pull Request is not marked as draft and it's not blocked by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: RHEL-50651