(RHEL-56793) repart: avoid use of uninitialized TPM2B_PUBLIC data #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
github-actions
bot
added
pr/needs-ci
Commit validationTracker - RHEL-56793 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-56793 has set desired product: Pull Request validationSuccess🟡 CI - Waived Auto MergeSuccess🟢 Pull Request is not marked as draft and it's not blocked by |
github-actions
bot
added
tracker/missing
The 'TPM2B public' struct is only initialized if the public key is non-NULL, however, it is unconditionally passed to tpm2_calculate_sealing_policy, resulting in use of uninitialized data. If the uninitialized data is lucky enough to be all zeroes, this results eventually results in an error message from tpm2_calculate_name about an unsupported nameAlg field value. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> (cherry picked from commit a3ad5c3) Resolves: RHEL-56793
jamacku
force-pushed
the
RHEL-56793-repart-tpm
branch
from
010560b to
db07cb0
Compare
|
CI failures are unrelated to these changes: |
github-actions
bot
removed
pr/needs-ci
github-actions
bot
merged commit 834137e
into
redhat-plumbers:main
28 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'TPM2B public' struct is only initialized if the public key is non-NULL, however, it is unconditionally passed to tpm2_calculate_sealing_policy, resulting in use of uninitialized data. If the uninitialized data is lucky enough to be all zeroes, this results eventually results in an error message from tpm2_calculate_name about an unsupported nameAlg field value.
Signed-off-by: Daniel P. Berrangé berrange@redhat.com
(cherry picked from commit a3ad5c3)
Resolves: RHEL-56793