remove global rand. Updating to a rand source per goroutine to avoid locking overhead #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipecosta90
requested changes
Sep 20, 2023
filipecosta90
changed the title
filipecosta90
approved these changes
Sep 20, 2023
|
Thank you @andydunstall . Merging... :) EDIT: released as part of https://github.com/redis-performance/redis-zbench-go/releases/tag/v0.0.3 |
|
Great thanks for reviewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running against Redis/Dragonfly using Go 1.21.1 found the client was a bottleneck as the global
randfunctions were blocked on the global lock (Go locks globalrandfunctions when it sets a seed) - so updating to a rand source per goroutineRunning
./redis-zbench-go -mode load -r 100000locally against redis went from ~5 rps to ~15 rps (and lower CPU on the benchmark)