Skip to content

Conversation

@uglide
Copy link
Contributor

@uglide uglide commented Sep 30, 2025

Improve assertions to make tests compatible with RE

@jit-ci
Copy link

jit-ci bot commented Sep 30, 2025

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@mgravell
Copy link
Collaborator

Note that the failing size assertions are pretty new - if they're going to cause problems, we can probably just... not do that.

@uglide
Copy link
Contributor Author

uglide commented Sep 30, 2025

@mgravell, they are actually quite helpful for the case when the tested endpoint is not local but a remote RE cluster with some extra latency. I just need to fix some mistakes to make it work with both OSS and RE

* Add 8.4 to CI matrix integration.yml

* Update integration.yml

* Update integration.yml

* Update integration.yml
@mgravell
Copy link
Collaborator

@uglide what's the status of this one; still in progress? do you want me to take it over? or...?

@uglide
Copy link
Contributor Author

uglide commented Dec 5, 2025

@mgravell This PR is blocked until my PR to RediSearch will be backported to v8.0 and released as Redis v8.0.x and Redis v8.2.x

- 8.0 is for security fixes now, so the "current" version should be switched to 8.2
- 8.4 has stable release now
@uglide uglide marked this pull request as ready for review December 5, 2025 15:28
@uglide
Copy link
Contributor Author

uglide commented Dec 5, 2025

run integration tests

@uglide
Copy link
Contributor Author

uglide commented Dec 5, 2025

Testcase Errors Failures Skipped Total
NRedisStack.Tests.dll 0 10 277 821

---- Details for maintainers

@uglide
Copy link
Contributor Author

uglide commented Dec 5, 2025

run integration tests

@uglide
Copy link
Contributor Author

uglide commented Dec 5, 2025

Testcase Errors Failures Skipped Total
NRedisStack.Tests.dll 0 1 277 821

---- Details for maintainers

@uglide
Copy link
Contributor Author

uglide commented Dec 5, 2025

Testcase Errors Failures Skipped Total
NRedisStack.Tests.dll 0 0 277 821

---- Details for maintainers

@uglide
Copy link
Contributor Author

uglide commented Dec 8, 2025

run integration tests

@mgravell
Copy link
Collaborator

mgravell commented Dec 8, 2025

Re-running, but: one failure - looks unreliable / transient (I've seen this flip between pass/fail)

[xUnit.net 00:00:38.71] NRedisStack.Tests.Search.SearchTests.TestDocumentLoadWithDB_Issue352(endpointId: "standalone") [FAIL]
[xUnit.net 00:00:38.71] Assert.Equal() Failure: Values differ
[xUnit.net 00:00:38.72] Expected: 3
[xUnit.net 00:00:38.72] Actual: 1
[xUnit.net 00:00:38.72] Stack Trace:

@uglide
Copy link
Contributor Author

uglide commented Dec 8, 2025

Testcase Errors Failures Skipped Total
NRedisStack.Tests.dll 0 1 205 821

---- Details for maintainers

@uglide
Copy link
Contributor Author

uglide commented Dec 8, 2025

Testcase Errors Failures Skipped Total
NRedisStack.Tests.dll 0 0 205 821

---- Details for maintainers

@mgravell mgravell merged commit 1ca7020 into master Dec 8, 2025
32 of 33 checks passed
@mgravell mgravell deleted the im/align-tests-with-re branch December 8, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants