fix: race slice for list function of ring client (#2931)

* fix: race slice for list of ring client Signed-off-by: rfyiamcool <rfyiamcool@163.com> * fix: copy wrong list Co-authored-by: Nedyalko Dyakov <nedyalko.dyakov@gmail.com> --------- Signed-off-by: rfyiamcool <rfyiamcool@163.com> Co-authored-by: ofekshenawa <104765379+ofekshenawa@users.noreply.github.com> Co-authored-by: Nedyalko Dyakov <nedyalko.dyakov@gmail.com>
redis · Feb 20, 2025 · 30e7388 · 30e7388
1 parent 37accb4
commit 30e7388
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/ring.go b/ring.go
@@ -341,7 +341,8 @@ func (c *ringSharding) List() []*ringShard {
 
 	c.mu.RLock()
 	if !c.closed {
-		list = c.shards.list
+		list = make([]*ringShard, len(c.shards.list))
+		copy(list, c.shards.list)
 	}
 	c.mu.RUnlock()