Add test codes for search_commands.go #3285
Open
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tomfrombayesians , Thanks for your contribution! |
|
Hello @tomfrombayesians, there is a file |
ndyakov
requested changes
Feb 21, 2025
Comment on lines
+3
to
+11
| import ( | ||
| "reflect" | ||
|
|
||
| . "github.com/bsm/ginkgo/v2" | ||
| . "github.com/bsm/gomega" | ||
| "github.com/redis/go-redis/v9" | ||
| ) | ||
|
|
||
| var _ = Describe("FTAggregateQuery", func() { |
There was a problem hiding this comment.
should either be moved in search_test.go or move all the search_test.go logic here. Feel free to decide which file would you like to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Since this is my first PR, I added a very small test. Our team is developing Tom, an open-source AI agent that automates code maintenance tasks like writing unit tests. This code was created through collaboration between Tom and me.
Right now, our project is still private, but if you’re interested, you can sign up for the Beta Release Waitlist through this link to get notified when it becomes available.
By the way, I ran into an issue when trying to execute the tests as described in the CONTRIBUTE guide. Even after running a Redis server locally and setting the required port, I couldn’t get the full test suite to run properly. To work around this, I created a TestSuite function inside search_commands_test.go to run the Ginkgo test in isolation.
Please let me know if anything needs to be adjusted! Thanks :)