test(client): restore generic-transformers spec on current APIs#3214
Open
nkaradzhov wants to merge 1 commit intoredis:masterfrom
Open
test(client): restore generic-transformers spec on current APIs#3214nkaradzhov wants to merge 1 commit intoredis:masterfrom
nkaradzhov wants to merge 1 commit intoredis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was commented out during V5 development with the idea to uncomment once done, but it seems it was forgotten.
Note
Low Risk
Low risk: changes are limited to tests, but they may expose previously unrun assertions and fail CI if current transformer behavior differs from expectations.
Overview
Restores the
generic-transformersspec by uncommenting/reintroducing the full test suite and wiring it to the current v5-era APIs.Tests now use the new RESP2 transformer entry points (e.g.,
transformBooleanReply[2],transformDoubleReply[2],transformSortedSetReply[2]) and switch argument-building helpers to the modernBasicCommandParser+parse*functions forGEOSEARCHoptions, optional variadics, and slot range parsing.Written by Cursor Bugbot for commit c227f5d. This will update automatically on new commits. Configure here.