properly escaping queries with forward slashes (#322)

redis · Mar 14, 2023 · b95ac22 · b95ac22
1 parent 8d05d91
commit b95ac22
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 1 deletion.
diff --git a/src/Redis.OM/Common/ExpressionParserUtilities.cs b/src/Redis.OM/Common/ExpressionParserUtilities.cs
@@ -26,7 +26,7 @@ internal static class ExpressionParserUtilities
         private static readonly char[] TagEscapeChars =
         {
             ',', '.', '<', '>', '{', '}', '[', ']', '"', '\'', ':', ';',
-            '!', '@', '#', '$', '%', '^', '&', '*', '(', ')', '-', '+', '=', '~', '|', ' ',
+            '!', '@', '#', '$', '%', '^', '&', '*', '(', ')', '-', '+', '=', '~', '|', ' ', '/',
         };
 
         /// <summary>

diff --git a/test/Redis.OM.Unit.Tests/RediSearchTests/SearchFunctionalTests.cs b/test/Redis.OM.Unit.Tests/RediSearchTests/SearchFunctionalTests.cs
@@ -1008,6 +1008,15 @@ public void TestIntSelects()
             collection.Delete(obj);
         }
 
+        [Fact]
+        public void TestQueryWithForwardSlashes()
+        {
+            var collection = new RedisCollection<ObjectWithZeroStopwords>(_connection);
+            collection.Insert(new ObjectWithZeroStopwords() { Name = "a/test/string" });
+
+            Assert.NotNull(collection.FirstOrDefault(x=>x.Name == "a/test/string"));
+        }
+
         [Fact]
         public void TestComplexObjectsWithMixedNesting()
         {

diff --git a/test/Redis.OM.Unit.Tests/RediSearchTests/SearchTests.cs b/test/Redis.OM.Unit.Tests/RediSearchTests/SearchTests.cs
@@ -2889,6 +2889,24 @@ public void TestNullableEnumQueries()
             ));
         }
 
+        [Fact]
+        public void TestEscapeForwardSlash()        
+        {
+            _mock.Setup(x => x.Execute(It.IsAny<string>(), It.IsAny<string[]>()))
+                .Returns(_mockReply);
+
+            var collection = new RedisCollection<Person>(_mock.Object);
+            collection.Where(x => x.TagField == "a/test/string").ToList();
+            _mock.Verify(x => x.Execute(
+                "FT.SEARCH",
+                "person-idx",
+                "(@TagField:{a\\/test\\/string})",
+                "LIMIT",
+                "0",
+                "100"
+                ));
+        }
+
         [Fact]
         public void TestMixedNestingIndexCreation()
         {