normalizing json serialization settings in statemanager #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NullValueHandling = NullValueHandling.Ignore, | ||
| DateFormatHandling = DateFormatHandling.IsoDateFormat, | ||
| DateParseHandling = DateParseHandling.DateTimeOffset, | ||
| DateTimeZoneHandling = DateTimeZoneHandling.Utc, |
There was a problem hiding this comment.
is this the main thing that forces it to UTC as where before it was using the user's local TZ?
There was a problem hiding this comment.
Redis OM converts all DateTime's to epochs for storage - this makes them queryable in an index. Previously, they were not being properly converted in the Update method - the Update method handles 1 or many individual updates to documents tracked (or untracked) by the RedisCollection - I fixed that issue in the previous PR mentioned above. There is another route (Save) for which we were still not managing this properly (hence the fix).
jeremyplichta
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504
We recently fixed an issue with DateTime's / DateTimeOffsets not being properly serialized in
Updateso they were coming up as false positives, unfortunately that does not appear to have propagated over to theSavefeature. This PR normalizes those serialization settings, so that should not happen anymore.